ibusManager: Change return value of `setCompletionEnabled()`

The return value currently indicates whether the request was
successful, namely `setCompletionEnabled(false)` will return
`true` if completions were successfully disabled.

However the only caller that uses the value uses it to indicate
whether completions were enabled.

Given that nothing else uses the value, change the meaning to
match the caller, and indicate whether completions are enabled
after the call returns.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3439>

diff --git a/js/misc/ibusManager.js b/js/misc/ibusManager.js
index a4931cfb9c322db28aa541b7ed4f19b0dc9c31a5..8d49735648a7cfa143f74be8bbb24c4d27886458 100644 (file)
--- a/js/misc/ibusManager.js
+++ b/js/misc/ibusManager.js
@@ -333,6 +333,11 @@ class IBusManager extends Signals.EventEmitter {
                 });
     }
 
+    /**
+     * @param {boolean} enabled - whether completion should be enabled
+     *
+     * @returns {boolean} - whether completion are enabled
+     */
     async setCompletionEnabled(enabled) {
         /* Needs typing-booster available */
         if (enabled && !this._engines.has(TYPING_BOOSTER_ENGINE))
@@ -342,7 +347,7 @@ class IBusManager extends Signals.EventEmitter {
             return false;
 
         if (this._oskCompletion === enabled)
-            return true;
+            return enabled;
 
         this._oskCompletion = enabled;
 
@@ -353,6 +358,6 @@ class IBusManager extends Signals.EventEmitter {
             await this._setEngine(this._preOskEngine);
             delete this._preOskEngine;
         }
-        return true;
+        return this._oskCompletion;
     }
 }